-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fully vueify notifications #4913
Merged
Merged
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
9f6859f
Started vueifying config_notifications.mako
p0psicles 0b49ed0
Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…
p0psicles 6ae2f6a
Added ConfigToggleSlider to index.js.
p0psicles 1081768
Reverted some indents.
p0psicles c2e7bfb
Sync themes.
p0psicles ac9280c
Add kodi.password to apiv2.
p0psicles bba1d01
Added config-textbox component to index.js.
p0psicles 78f8dd7
Updated store with missing attributes.
p0psicles f54cf0a
Use config-toggle-slider for kodi checkboxes.
p0psicles 154f9e4
Add plex server section.
p0psicles fbed61e
Added plex home theater.
p0psicles 1a66e10
Move notifications to data_section.
p0psicles 08b01f4
Added store notifiers.js, as notifications.js is already used by some…
p0psicles 477a2e4
Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…
p0psicles 28aaa95
Webpack Build, xo and gulp sync.
p0psicles 39ebda0
Merge branch 'develop' into feature/fully-vueify-notifications
sharkykh 16ca8b7
Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…
p0psicles 24b1f8a
Added notification sections emby, nmj and nmjv2.
p0psicles b7eac52
Added synology index, synology notifier and pyTivo to Apiv2.
p0psicles 70aa7cc
Added synology index, synology notifier and pyTivo to config_notifica…
p0psicles 6904579
Added growl notifications.
p0psicles 9627847
Added prowl notifier.
p0psicles 1f8cff4
Added sections:
p0psicles f2129bf
Added notifiers:
p0psicles db556ce
Fully vueified twitter.
p0psicles 1fc9918
Vueified trakt section.
p0psicles 1ec14af
Removed the watch on the editItems and replaced these with @change ev…
p0psicles 98621b3
Vueified email section.
p0psicles e41a333
Fixed sending test email.
p0psicles 67b8846
Vueified section slack.
p0psicles c6d64a7
Add saving.
p0psicles a03bb05
Fixed saving email addressList.
p0psicles ca7bc81
email: initialize addressList as array.
p0psicles c5e472b
Map select-list emitted values to x.value.
p0psicles 0e54a05
Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…
p0psicles 43b316a
Fix xo errors.
p0psicles a352f76
Run build dev
p0psicles 55e777c
Added notifiers section to api-description.yml
p0psicles bd315cd
Moved config/search response definition to correct location.
p0psicles 7f73d90
Standardize the notify.snatch => notifyOnSnatch.
p0psicles 4fe942b
Email subject typo.
p0psicles 7f8f262
Yarn dev instead of production build.
p0psicles 4ffbcae
Removed debugger
p0psicles 4fc7039
Updated changelog.
p0psicles e8c9ccd
Fixed up jquery for:
p0psicles 2fb5984
Fixed some flake warnings.
p0psicles 53ea5aa
email port should be integer
medariox 24dc6eb
Fixed config-textbox-number
p0psicles 63ecad5
Fixed a number js issues. For testing notifiers.
p0psicles 2b77012
Fix snapshot tests for show-selector.
p0psicles 770f115
Fixed show-selector tests.
p0psicles ef7b1d1
Bump test requirement pycodestyle version.
p0psicles 392f7f8
Merge branch 'develop' into feature/fully-vueify-notifications
p0psicles a88d41c
Added blank line.
p0psicles 959c8b5
Update pytest test_config.py config/main fixture.
p0psicles 08c0644
Fix fixture for test_config_get_detailed.
p0psicles ac906f3
Added a new component config-template.vue
p0psicles def435b
Optimize the usage of v-bind.
p0psicles 6ed3c74
Renamed selectedShowList to selectedShowSlug.
p0psicles 0016d5c
Removed the jquery on click handlers.
p0psicles 1f8adc3
Added (fixed) snotify.
p0psicles 9cc67c1
Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…
p0psicles 3fa238d
Build themes.
p0psicles b6c3e4b
split notifiers into dir
OmgImAlexis 2bef98f
Recreated snapshots for config-textbox* components.
p0psicles 079bac2
Merge branch 'develop' into feature/fully-vueify-notifications
p0psicles 869c190
Destructured object variables for components, where needed.
p0psicles 8b10bb7
Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…
p0psicles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added store notifiers.js, as notifications.js is already used by some…
…thing else.
- Loading branch information
commit 08b01f4a3dc53a187bd6eb9262f01da1bc2030a4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
import { ADD_CONFIG } from '../mutation-types'; | ||
|
||
const state = { | ||
emby: { | ||
enabled: null, | ||
host: null | ||
}, | ||
kodi: { | ||
enabled: null, | ||
alwaysOn: null, | ||
libraryCleanPending: null, | ||
cleanLibrary: null, | ||
host: [], | ||
username: null, | ||
password: null, | ||
notify: { | ||
snatch: null, | ||
download: null, | ||
subtitleDownload: null | ||
}, | ||
update: { | ||
library: null, | ||
full: null, | ||
onlyFirst: null | ||
} | ||
}, | ||
plex: { | ||
client: { | ||
host: [], | ||
username: null, | ||
enabled: null, | ||
notifyOnSnatch: null, | ||
notifyOnDownload: null, | ||
notifyOnSubtitleDownload: null | ||
}, | ||
server: { | ||
updateLibrary: null, | ||
host: [], | ||
enabled: null, | ||
https: null, | ||
username: null, | ||
password: null, | ||
notify: { | ||
download: null, | ||
subtitleDownload: null, | ||
snatch: null | ||
} | ||
} | ||
} | ||
}; | ||
|
||
const mutations = { | ||
[ADD_CONFIG](state, { section, config }) { | ||
if (section === 'notifiers') { | ||
state = Object.assign(state, config); | ||
} | ||
} | ||
}; | ||
|
||
const getters = {}; | ||
|
||
const actions = {}; | ||
|
||
export default { | ||
state, | ||
mutations, | ||
getters, | ||
actions | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to play around with this but I think it'll be better off if we split the notifers into modules.
Click me for diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add these changes to the branch please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally i'm okay with having all these notifiers in one file. It doesn't bother me having them in one file. I think it's organized enough. But maybe there are other more technical reasons to split them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for splitting them is to keep each module separate. I'm thinking we could move the notifier tests into each notifier which means we can then call
this.$store.dispatch('notifier/kodi/test', {})
for example before we save and that'llresolve/reject
.