Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the amount of expected titles created. #10493

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Reduce the amount of expected titles created. #10493

merged 3 commits into from
Apr 12, 2022

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Apr 12, 2022 •
edited
Loading

  • When the option Append (year) to each show title is enabled.
  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Fix #10483

@p0psicles
Reduce the amount of expected titles created.
2e83ca1 
* When the option `Append (year) to each show title` is enabled.
@p0psicles p0psicles added this to the 1.0.0 milestone Apr 12, 2022
@p0psicles
The regex for year should include parenthises.
54629db 
For example:
"(2022)" excluded from expected title.
"2022" included from expected title.
@p0psicles
Merge remote-tracking branch 'origin/develop' into feature/reduce-exp…
69e8929 
…ected-titles
@p0psicles p0psicles merged commit 9fe760e into develop Apr 12, 2022
@p0psicles p0psicles deleted the feature/reduce-expected-titles branch April 12, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@p0psicles