Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse re.Pattern object in regex patterns #1318

Merged
merged 17 commits into from
Jun 11, 2024
Merged

Reuse re.Pattern object in regex patterns #1318

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
43d4dbb
initial work for regex fix
sydney-runkle Jun 6, 2024
579db3a
basic support
sydney-runkle Jun 6, 2024
c34df34
checkpoint, things are working
sydney-runkle Jun 6, 2024
8c15026
reorganizing things to use explicit pattern strings
sydney-runkle Jun 6, 2024
9903a32
use python-re whenever pattern is compiled
sydney-runkle Jun 10, 2024
348029a
add pattern support in generate_self_schema
sydney-runkle Jun 10, 2024
c26307d
str not string?
sydney-runkle Jun 10, 2024
3aa3985
use any in the meantime
sydney-runkle Jun 10, 2024
2a64e16
consistent comments
sydney-runkle Jun 10, 2024
9bb53d8
fix for 3.12.4+
sydney-runkle Jun 10, 2024
6bddb4b
Merge branch 'main' into regex-fix
sydney-runkle Jun 10, 2024
b9dad9d
revert eval fix
sydney-runkle Jun 10, 2024
1d1f12a
versioned approach
sydney-runkle Jun 10, 2024
6ee8b04
support for 3.12.4
sydney-runkle Jun 10, 2024
31cac08
get tests passing
sydney-runkle Jun 10, 2024
2ad5724
fix things again for eval_forward_ref
sydney-runkle Jun 10, 2024
4555a1a
check compiled pattern uses flags in test
sydney-runkle Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert eval fix
  • Loading branch information
@sydney-runkle
sydney-runkle committed Jun 10, 2024
commit b9dad9df18ed972ec390fef7db4d4f27c25ccbcf
4 changes: 2 additions & 2 deletions generate_self_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,11 @@ def all_literal_values(type_: type[core_schema.Literal]) -> list[any]:
def eval_forward_ref(type_: Any) -> Any:
try:
try:
# Python 3.12.4+
# Python 3.12+
return type_._evaluate(core_schema.__dict__, None, type_params=set(), recursive_guard=set())
except TypeError:
# Python 3.9+
return type_._evaluate(core_schema.__dict__, None, recursive_guard=set())
return type_._evaluate(core_schema.__dict__, None, set())
except TypeError:
# for Python 3.8
return type_._evaluate(core_schema.__dict__, None)
Expand Down
Loading