feat(types): Adds support for Typing.Callable Special Case #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@InvincibleRMC If you have more of these, is there a chance that you could combine them, to reduce the churn here? I'm also curious: Why/how do you decide what to add? Is this feeding into something specific? |
henryiii
approved these changes
Jun 26, 2024
|
I don't have anymore implementations that currently work. I've been trying to get Protocol/TypeDict/Generic working but, no luck so far. For choosing what to add I have mostly just been going through Python's typing api and attempting to add them into typing.h. I don't have any specific need right now but, in the future I'm hoping to improve https://github.com/ros2/rclpy pybinded types. |
henryiii
changed the title
henryiii
added
needs backport
and removed
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for special case defined by pep 484.
Suggested changelog entry:
Add support for ``Typing.Callable[..., T]``