Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): findpython issues and 3.12 support for pybind11_find_import #4941

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Nov 15, 2023

Fixing FindPython mode, which wasn't exporting the version number or Python_EXECUTABLE, which caused things like pybind11_find_import to break.

Also fixing pybind11_find_import to try importlib.metadata first, since pkg_resources is a third-party library and not always present, especially on Python 3.12.

Suggested changelog entry:

Fix FindPython mode exports & avoid ``pkg_resources`` if ``importlib.metadata`` available.

@henryiii henryiii merged commit 9591cfb into pybind:master Nov 16, 2023
84 checks passed
@henryiii henryiii deleted the henryiii/fix/cmakesubdirfindpy branch November 16, 2023 05:54
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Nov 16, 2023
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants