chore: update hooks and Ruff config #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
commented
Oct 26, 2023
| @@ -157,7 +157,7 @@ py::array mkarray_via_buffer(size_t n) { | |||
| do { \ | |||
| (s).bool_ = (i) % 2 != 0; \ | |||
| (s).uint_ = (uint32_t) (i); \ | |||
| (s).float_ = (float) (i) *1.5f; \ | |||
| (s).float_ = (float) (i) * 1.5f; \ | |||
There was a problem hiding this comment.
Nice clang-format update. :)
rwgk
reviewed
Oct 26, 2023
| @@ -662,8 +662,8 @@ TEST_SUBMODULE(pytypes, m) { | |||
| // This is "most correct" and enforced on these platforms. | |||
There was a problem hiding this comment.
But why is it now also indenting this?
Just wondering. Maybe we get more free spaces here in the next upgrade?
rwgk
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the hooks and update Ruff's config. Preparing for ruff-format.