Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Reenable an NVHPC Test #4764

Merged
merged 2 commits into from
Aug 4, 2023
Merged

CI: Reenable an NVHPC Test #4764

merged 2 commits into from
Aug 4, 2023

Conversation

ax3l
Copy link
Collaborator

@ax3l ax3l commented Jul 26, 2023

Description

Update from CentOS to Ubuntu and to a recent version of NVHPC (former: PGI).

Fix #4690
Follow-up to #4691

Suggested changelog entry:

* CI: Update NVHPC to 23.5 and Ubuntu 20.04

@ax3l ax3l added the ci related to the CI system label Jul 26, 2023
@ax3l ax3l requested a review from henryiii as a code owner July 26, 2023 17:56
@ax3l ax3l force-pushed the ci-nvhpc-reenable branch 5 times, most recently from 592b0ce to 244c1a2 Compare July 26, 2023 18:26
Update from CentOS to Ubuntu and to a recent version
of NVHPC (former: PGI).
@rwgk
Copy link
Collaborator

rwgk commented Jul 26, 2023

BTW: I'm testing a fix for the Clang dev failure:

1fb7dc3

Good to ignore here.

-DCMAKE_CXX_STANDARD=11 \
module load /opt/nvidia/hpc_sdk/modulefiles/nvhpc/23.5
cmake -S . -B build -DDOWNLOAD_CATCH=ON \
-DCMAKE_CXX_STANDARD=17 \
-DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)") \
-DCMAKE_CXX_FLAGS="-Wc,--pending_instantiations=0" \
-DPYBIND11_TEST_FILTER="test_smart_ptr.cpp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is removed (seems great):

we have to filter a few tests (compiler internal error)

But we still have the PYBIND11_TEST_FILTER here. Could you please try removing it?

While you're at it, maybe also piggy-back 1fb7dc3?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, maybe also piggy-back 1fb7dc3?

No, don't, it breaks centos:7 :-(

https://github.com/pybind/pybind11/actions/runs/5672904152/job/15373167218

I'll sort this out separately.

@rwgk
Copy link
Collaborator

rwgk commented Aug 4, 2023

I just updated this PR to

  1. pull in the Clang Dev fix

  2. assuming GHA here are fine, merge this PR and retest feat: add py::set_error(), use in updated py::exception<> documentation #4772.

@rwgk rwgk merged commit 824dc27 into pybind:master Aug 4, 2023
82 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 4, 2023
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related to the CI system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINT]: CI / 🐍 3 • CentOS7 / PGI 22.9 • x64: GitHub runner disk size limit exceeded
4 participants