Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add descriptive exception when fail to add instance to weakref dictionary #189

Merged
merged 3 commits into from
Aug 18, 2023
Merged

fix: Add descriptive exception when fail to add instance to weakref dictionary #189

merged 3 commits into from
Aug 18, 2023

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Aug 18, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15% 🎉

Comparison is base (8457563) 86.18% compared to head (466a195) 86.34%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   86.18%   86.34%   +0.15%     
==========================================
  Files          36       36              
  Lines        2780     2783       +3     
==========================================
+ Hits         2396     2403       +7     
+ Misses        384      380       -4
Files Changed Coverage Δ
src/superqt/utils/_throttler.py 93.52% <100.00%> (+2.34%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member

now I think we've got it covered for sure! thanks! :)

@tlambert03 tlambert03 added the bug Something isn't working label Aug 18, 2023
@tlambert03 tlambert03 changed the title Add descriptive exception when fail to add instance to weakref dictionary fix: Add descriptive exception when fail to add instance to weakref dictionary Aug 18, 2023
@tlambert03 tlambert03 merged commit 462eead into pyapp-kit:main Aug 18, 2023
40 checks passed
@Czaki Czaki deleted the weakref_info branch August 18, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlambert03 tlambert03 tlambert03 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Czaki @tlambert03