Clone Git monorepos with several dependencies only once #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
commented
Aug 27, 2024
Comment on lines
12
to
27
| deku: | ||
| git: https://github.com/mikesol/purescript-deku.git | ||
| subdir: deku | ||
| ref: 276f48adde3d9354f61917f7e9ae2ae7b43df6b2 | ||
| deku-core: | ||
| git: https://github.com/mikesol/purescript-deku.git | ||
| subdir: deku-core | ||
| ref: 98c67533cc8c399aa643b495d3c02bab963e5b80 | ||
| deku-css: | ||
| git: https://github.com/mikesol/purescript-deku.git | ||
| subdir: deku-css | ||
| ref: 4e68a5cec10c91aa3377ce69cc97c276936a1194 | ||
| deku-dom: | ||
| git: https://github.com/mikesol/purescript-deku.git | ||
| subdir: deku-dom | ||
| ref: 6b7c392da7782fe0f2e34811e36b11e630e10b26 |
There was a problem hiding this comment.
I used Mike's example from #1208, but with specific SHAs. This should be fine until the repo is deleted or its history is rewritten.
fsoikin
force-pushed
the
no-double-git-cloning
branch
from
8969f96
to
ade6fee
Compare
fsoikin
commented
Aug 27, 2024
fsoikin
force-pushed
the
no-double-git-cloning
branch
from
ce182d4
to
0b2193a
Compare
f-f
reviewed
Aug 27, 2024
core/src/FS.purs
Outdated
| @@ -15,6 +15,7 @@ module Spago.FS | |||
| , readTextFile | |||
| , readYamlDocFile | |||
| , readYamlFile | |||
| , rmRf | |||
There was a problem hiding this comment.
I wouldn't like this in application code - it looks like it's only used for tests so we should move it into the Test Prelude or just in the Test.Spago.Build.Monorepo module
fsoikin
force-pushed
the
no-double-git-cloning
branch
from
98e384a
to
1c71e40
Compare
fsoikin
force-pushed
the
no-double-git-cloning
branch
from
f7df94a
to
9c4bcde
Compare
|
@fsoikin could I ask you to not force-push? Seeing all the commits is actually useful for reviewing things, and we squash-merge all the PRs so there's no effect on what ends up in trunk. |
f-f
reviewed
Aug 27, 2024
fsoikin
commented
Aug 28, 2024
fsoikin
commented
Aug 28, 2024
2 tasks
|
Thank you, we have tested this and it works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixed #1208
.spago/g/.Checklist:
[ ] Added some example of the new feature to theREADME