Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ✅ ❌ ⚠️ emoji with ✓✘⚠ respectively #1258

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

fsoikin
Copy link
Contributor

@fsoikin fsoikin commented Jul 26, 2024

Description of the change

Fixes #1183

In Windows Terminal

image

In GNOME Terminal

image

In ConEmu on Windows

image

I cannot verify on a Mac.

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • [ ] Added some example of the new feature to the README
  • [ ] Added a test for the contribution (if applicable)

@fsoikin fsoikin changed the title Replace ✅ ❌ ⚠️ emoji with ✔ ✖ ⚠ respectively and hide them in monochrome mode Replace ✅ ❌ ⚠️ emoji with ✓✘⚠ respectively Jul 28, 2024
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@f-f f-f merged commit 413d3cf into purescript:master Jul 29, 2024
5 checks passed
@fsoikin fsoikin deleted the emoji branch July 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to opt out of CLI emoji via spago.yaml, env var, and/or flag
2 participants