Rubocopification #731
Merged
Rubocopification #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmeek
force-pushed
the
rubocopification
branch
from
27e7817
to
d4c3244
Compare
pmcmaw
reviewed
Nov 15, 2017
.rubocop.yml
Outdated
| @@ -95,4 +95,4 @@ Style/AsciiComments: | |||
| Style/IfUnlessModifier: | |||
| Enabled: false | |||
| Style/SymbolProc: | |||
| Enabled: false | |||
| Enabled: false | |||
There was a problem hiding this comment.
Can you remove the line break at the end of this line.
There was a problem hiding this comment.
Thanks Paula, it looks like it was actually missing a line break, which was why github was highlighting it with an icon.
I've added a line break, should look ok now :)
There was a problem hiding this comment.
It now looks to be consistent with the previous .rubocop.yml hat TP had in, that we were using as reference, so won't show on the diff :)
willmeek
force-pushed
the
rubocopification
branch
from
d4c3244
to
438a48a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.