Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UserFileDefaultOptions#fetch to properly consume default value #2233

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

ayufan
Copy link
Contributor

@ayufan ayufan commented Apr 24, 2020

Description

The usage of || fetch is incorrect, as presence of false is the correct value.
This change uses default value, only if the value is nowhere else defined.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@ayufan
Copy link
Contributor Author

ayufan commented Apr 24, 2020

cc @nateberkopec

@ayufan ayufan changed the title Fix UserFileDefaultOptions#fetch implementation Fix UserFileDefaultOptions#fetch to properly consume default value Apr 24, 2020
The usage of `||` fetch is incorrect,
as presence of `false` is the correct value.

This change uses `default` value,
only if the value is nowhere else defined.
@ayufan
Copy link
Contributor Author

ayufan commented Apr 24, 2020

The test_out_of_band_stream is flaky, as it is too fast to execute. The flaky aspect of test is solved by #2079.

@nateberkopec nateberkopec merged commit 883b861 into puma:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants