Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some opcodes #936

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Added some opcodes #936

merged 2 commits into from
Aug 18, 2023

Conversation

wannacu
Copy link
Contributor

@wannacu wannacu commented Aug 17, 2023

No description provided.

ptitSeb
ptitSeb requested changes Aug 17, 2023
View reviewed changes
Copy link
Owner

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RV64 Atomic Read/Write doesn't support too many opcode between read and write. The ADC32 will not work on certain hardware with certain case as it's done right now.

@wannacu wannacu requested a review from ptitSeb August 18, 2023 02:20
ptitSeb
ptitSeb requested changes Aug 18, 2023
View reviewed changes
Copy link
Owner

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, more changes requested.

@wannacu wannacu requested a review from ptitSeb August 18, 2023 09:39
@wannacu wannacu requested a review from ptitSeb August 18, 2023 10:44
@ptitSeb
Copy link
Owner

ptitSeb commented Aug 18, 2023

Thanks, that's a big one.

@ptitSeb ptitSeb merged commit 77161c8 into ptitSeb:main Aug 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb Awaiting requested review from ptitSeb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wannacu @ptitSeb