Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DYNAREC_RV64] Minor OF flag fixes and optimizations for emit shift utils #1275

Merged
merged 2 commits into from
Feb 21, 2024
Merged

[DYNAREC_RV64] Minor OF flag fixes and optimizations for emit shift utils #1275

merged 2 commits into from
Feb 21, 2024

Conversation

ksco
Copy link
Collaborator

@ksco ksco commented Feb 21, 2024

No description provided.

@ksco
Copy link
Collaborator Author

ksco commented Feb 21, 2024

Interestingly, test.vmp.exe is now working on RISC-V, the div by zero hack is not required.

@ptitSeb
Copy link
Owner

ptitSeb commented Feb 21, 2024

Interestingly, test.vmp.exe is now working on RISC-V, the div by zero hack is not required.

Ah, just accurate OF was enough? Good!
(still I suggest you add the div0 hack later)

@ptitSeb ptitSeb merged commit b179bd2 into ptitSeb:main Feb 21, 2024
32 checks passed
@ksco ksco deleted the optim branch February 21, 2024 10:34
@ksco
Copy link
Collaborator Author

ksco commented Feb 21, 2024

Ah, just accurate OF was enough? Good!

Yes!

(still I suggest you add the div0 hack later)

Yeah, of course, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksco @ptitSeb