Wrapped libraries refactor #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
reviewed
Feb 10, 2024
| #define PRE_INIT \ | ||
| if(box64_nogtk) \ | ||
| return -1; | ||
|
|
||
| #define CUSTOM_INIT \ | ||
| libname = lib->name; \ |
There was a problem hiding this comment.
this line about libname disapeared?
There was a problem hiding this comment.
Yes, libname is unused in the entire file.
ptitSeb
reviewed
Feb 10, 2024
| @@ -20,7 +20,7 @@ | |||
| #include "gtkclass.h" | |||
|
|
|||
| const char* gtkx112Name = "libgtk-x11-2.0.so.0"; | |||
| static char* libname = NULL; | |||
There was a problem hiding this comment.
this was here because it use to be able to load gtk-1 also. I guess this is obsolete and can be remove completly, especially on 64bits?
There was a problem hiding this comment.
Yes. wrappedgdkx112.c still requires it, but wrappedgtkx112.c does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors various common operations on wrapped libraries initialization/finalization:
getMy(lib)inCUSTOM_INITandfreeMy()inCUSTOM_FINI, toggled by theHAS_MYmacro;SETALTinCUSTOM_INITinto theALTMYmacro;setNeededLibs(lib, n, ...)inCUSTOM_INIT, called with the correctnusing theNEEDED_LIBSmacro.