Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Elixir Version #3

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Updates Elixir Version #3

merged 1 commit into from
Oct 25, 2020

Conversation

naomijub
Copy link
Contributor

  • Elixir version 1.10
  • Updates deps
  • Includes formatter and credo
  • Applies credo's suggestions
  • Include Github Actions

- Updates deps
- Includes formatter and credo
- Applies credo's suggestions
- Include Github Actions
@naomijub naomijub mentioned this pull request Oct 23, 2020
@psfblair psfblair merged commit 17736c2 into psfblair:master Oct 25, 2020
@psfblair
Copy link
Owner

Hello @naomijub --

Unfortunately, after merging the commit I find that the build is broken, with the following message. I also see

0s
1
Run mix test
2
mix test
3
shell: /bin/bash -e {0}
4
** (Mix) You're trying to run :exdn on Elixir v1.10.3 but it has declared in its mix.exs file it supports only Elixir ~> 1.11
5
Error: Process completed with exit code 1.
Post Restore dependencies cache

This looks like it comes from the following in elixir.yml:

   with:
     elixir-version: '1.10.3' # Define the elixir version [required]

I am also seeing that Github flagged the elixir.yml and the makefile for not ending with a newline.

Would you care to submit a PR to correct these issues? Thanks.

@naomijub naomijub mentioned this pull request Oct 26, 2020
@naomijub
Copy link
Contributor Author

This should help. #4
The problem is that most CI use docker hub to run, and there is no 1.11 elixir docker container yet. However, github actions downloads elixir 1.11 to run.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants