In docs, use intersphinx to link to Python documentation #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4678 +/- ##
=======================================
Coverage 66.79% 66.79%
=======================================
Files 15 15
Lines 1563 1563
=======================================
Hits 1044 1044
Misses 519 519Continue to review full report at Codecov.
|
|
Hey @jdufresne, thanks for helping simplify this. Would you mind rebasing this onto the current tip of master? |
|
Rebased. Thanks |
nateprewitt
previously approved these changes
Aug 11, 2018
There was a problem hiding this comment.
Hey @jdufresne, it looks like I missed the email last time you rebased this. Would you mind rebasing once more and we can get this merged? Thanks!
The intersphinx extension can generate automatic links to the documentation of objects in other projects. It was already used for urllib3. For complete details on intersphinx, see: http://www.sphinx-doc.org/en/master/ext/intersphinx.html
|
Rebased, thanks |
nateprewitt
approved these changes
Aug 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intersphinx extension can generate automatic links to the documentation of objects in other projects. It was already used for urllib3. For complete details on intersphinx, see:
http://www.sphinx-doc.org/en/master/ext/intersphinx.html