Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GPBWrapperUtil from generated code #5880

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Remove GPBWrapperUtil from generated code #5880

merged 2 commits into from
Mar 13, 2019

Conversation

TeBoring
Copy link
Contributor

@TeBoring TeBoring commented Mar 13, 2019 •
edited
Loading

Fixes #5879

@TeBoring
Copy link
Contributor Author

@michaelbausor PTAL

@TeBoring TeBoring mentioned this pull request Mar 13, 2019
Closed
michaelbausor
michaelbausor reviewed Mar 13, 2019
View reviewed changes
Copy link
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TeBoring TeBoring added this to the v3.7.0 milestone Mar 13, 2019
@TeBoring TeBoring added the php label Mar 13, 2019
@TeBoring TeBoring merged commit 207d01d into protocolbuffers:3.7.x Mar 13, 2019
@TeBoring TeBoring deleted the php-fix2 branch March 13, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbausor michaelbausor michaelbausor left review comments

Assignees
No one assigned
Labels
cla: yes php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeBoring @michaelbausor @googlebot