Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 3.7.0 #5749

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Update version to 3.7.0 #5749

merged 2 commits into from
Feb 19, 2019

Conversation

TeBoring
Copy link
Contributor

No description provided.

@TeBoring TeBoring requested review from acozzette and a user February 19, 2019 20:58
@ghost
Copy link

ghost commented Feb 19, 2019

BTW, did we append the -rc2 suffix by hands?

@TeBoring
Copy link
Contributor Author

@acozzette How did you do that?
I think we have to do it manually currently. Different languages use different style.

@ghost
Copy link

ghost commented Feb 19, 2019

@acozzette How did you do that?
I think we have to do it manually currently. Different languages use different style.

https://github.com/protocolbuffers/protobuf/blob/master/update_version.py handles each language separately. I wasn't sure the style for each language before, but I can use this as an example.

@acozzette
Copy link
Member

I ran Hao's script to update the version to 3.8.0, and then I went through and replaced 3.8.0 with 3.7.0-rc2. I had to do it that way because the script doesn't know how to do rc releases yet, but I wanted to run it anyway to make sure I didn't miss any places that needed to be updated.

@TeBoring
Copy link
Contributor Author

@haon4 SG.

@ghost
Copy link

ghost commented Feb 19, 2019

#5750 to support the rc suffix in update_version.

@TeBoring TeBoring merged commit c7b3392 into protocolbuffers:3.7.x Feb 19, 2019
@TeBoring TeBoring deleted the 3.7.x-fix branch February 22, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants