Add new version of the restricted kernel simple_io and initrd #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new oak_restricted_kernel_simple_io_init_rd_wrapper will exist alongside oak_restricted_kernel_simple_io_wrapper for a while. then internal dependencies will be updated, and the the former will be removed. this approach is significatnly simpler than #. For project-oak#4828 we would need to attempt to synchronize its merging with the updates to the internal launcher and the transparent release imports of the binary. It'd be too flaky.
thmsbinder
approved these changes
Mar 15, 2024
| @@ -42,6 +43,7 @@ readonly generated_binaries=( | |||
| ) | |||
| readonly binary_names=( | |||
| oak_restricted_kernel_simple_io_wrapper_bin | |||
| oak_restricted_kernel_simple_io_init_rd_wrapper_bin | |||
There was a problem hiding this comment.
I assume the new one would also behave like a bzImage (i.e. a kernel-type endorsement) since it is named "wrapper".
conradgrobler
approved these changes
Mar 15, 2024
| @@ -42,6 +43,7 @@ readonly generated_binaries=( | |||
| ) | |||
| readonly binary_names=( | |||
| oak_restricted_kernel_simple_io_wrapper_bin | |||
| oak_restricted_kernel_simple_io_init_rd_wrapper_bin | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new oak_restricted_kernel_simple_io_init_rd_wrapper will exist alongside oak_restricted_kernel_simple_io_wrapper for a while. then internal dependencies will be updated, and the the former will be removed.
this approach is significantly simpler than #4828. For #4828 we would need to attempt to synchronize its merging with the updates to the internal launcher and the transparent release imports of the binary. It'd be too flaky.