Generate empty attestation config #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by the restricted kernel SDK
… evidence as OakRestrictedKernel
bmclarnon
approved these changes
Feb 15, 2024
| @@ -23,10 +23,15 @@ | |||
|
|
|||
| extern crate alloc; | |||
|
|
|||
| use alloc::vec; | |||
|
|
|||
There was a problem hiding this comment.
nit: extra newline? Or do you treat alloc differently?
There was a problem hiding this comment.
automatically formatted by rustfmt. its ways are mysterious
There was a problem hiding this comment.
The new format used by rustfmt groups core/alloc/std together, all third-party ctates together and all local crate:: imports together.
conradgrobler
approved these changes
Feb 16, 2024
| @@ -23,10 +23,15 @@ | |||
|
|
|||
| extern crate alloc; | |||
|
|
|||
| use alloc::vec; | |||
|
|
|||
There was a problem hiding this comment.
The new format used by rustfmt groups core/alloc/std together, all third-party ctates together and all local crate:: imports together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is currently not populated by the restricted kernel, as there is no application config. However, the verification library expects it.
Depending on preference, this field should either be populated with an empty value (this PR) or removed #4807.
Those PRs are mutually exclusive. But one should be merged, for restricted kernel evidence to be parsed in the verification library.