Permit page table static to be updated #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jul-sh
force-pushed
the
pt-swap
branch
2 times, most recently
from
3b00f0d
to
06b1acd
Compare
jul-sh
commented
Feb 12, 2024
Comment on lines
+281
to
+286
| /// Replaces the current pagetable with the parameter, returning the old | ||
| /// pagetable if there was one. Does not issue the instructions update the | ||
| /// page table on the CPU level. | ||
| pub fn replace(&mut self, new_pt: RootPageTable) -> Option<RootPageTable> { | ||
| self.inner.replace(new_pt) | ||
| } |
There was a problem hiding this comment.
This isn't used yet, but will be in the future
conradgrobler
approved these changes
Feb 12, 2024
| @@ -267,3 +267,35 @@ impl Translator for RootPageTable { | |||
| self.inner.translate_physical_frame(frame) | |||
| } | |||
| } | |||
|
|
|||
| /// Wrapper struct that holds the current page table is there one. | |||
| pub struct CurrentPageTable { | |||
There was a problem hiding this comment.
nit: perhaps emphasize the fact that this is the current root page table in the name (e.g. CurrentRootPageTable)
| inner: Option<RootPageTable>, | ||
| } | ||
|
|
||
| impl CurrentPageTable { |
There was a problem hiding this comment.
This doesn't seem to add much over just using Option<RootPageTable, apart from changing the names of some functions. Do you plan on adding more functionality to this wrapper in future?
There was a problem hiding this comment.
I would expect it to later on update the pagetable on the CPU level upon updating.
The other difference is that it cannot be set back to None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.