Log binary hash of the loaded application #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did this in a different place before I removed it in project-oak#4755. I think it's nice to keep.
tiziano88
approved these changes
Feb 5, 2024
oak_restricted_kernel/src/lib.rs
Outdated
| let app_digest = oak_restricted_kernel_dice::measure_app_digest(&application_bytes); | ||
|
|
||
| log::info!( | ||
| "Binary hash: {}", |
There was a problem hiding this comment.
(nit) for consistency?
Suggested change
| "Binary hash: {}", | |
| "Application digest: {}", |
There was a problem hiding this comment.
Could you also print what hash function is used? is it sha2-256? If so, perhaps we should rename measure_app_digest to include the hash type itself, to avoid confusion if / when we support other ones? In fact perhaps rename AppDigest to AppDigestSha2_256 or something like that?
conradgrobler
approved these changes
Feb 6, 2024
oak_restricted_kernel/src/lib.rs
Outdated
| let app_digest = oak_restricted_kernel_dice::measure_app_digest(&application_bytes); | ||
|
|
||
| log::info!( | ||
| "Binary hash: {}", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did this in a different place before I removed it in #4755. I think it's nice to keep.