Consolidating micro_rpc protos under the top level proto package #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-naliuka
force-pushed
the
micro_rpc_protos
branch
from
67b85ba
to
2c667cb
Compare
|
Looks fine, but could you add some context in the PR description? |
Done, thanks! |
andrisaar
approved these changes
Nov 14, 2023
k-naliuka
added a commit
that referenced
this pull request
Nov 15, 2023
k-naliuka
added a commit
that referenced
this pull request
Nov 15, 2023
k-naliuka
added a commit
to k-naliuka/oak
that referenced
this pull request
Nov 15, 2023
k-naliuka
added a commit
to k-naliuka/oak
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the cleanup to move the protos from within Rust crate folders into a central more generic location (see issue #4392 for more context)