Add release scripts #2220
Merged
Add release scripts #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiziano88
force-pushed
the
tzn_release_scripts
branch
from
95b984d
to
f27ce98
Compare
conradgrobler
approved these changes
Jul 5, 2021
scripts/release_snapshot
Outdated
| echo '' | ||
| echo '[net]' | ||
| echo 'offline = true' | ||
| } >> .cargo/config |
There was a problem hiding this comment.
.cargo/config here is inconsistent with the comment in line 35 (.cargo/config.toml). Also, what happens if this is run multiple times? Will appending this to the file multiple times break anything, or is it up to whoever is running it to roll back changes before running it again?
There was a problem hiding this comment.
Renamed to config.toml. Also clarified that the script is not idempotent. The future playbook for releases will have more details about it.
tiziano88
force-pushed
the
tzn_release_scripts
branch
from
f27ce98
to
a287f56
Compare
Rename .cargo/config to .cargo/config.toml for consistency with https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure.
tiziano88
force-pushed
the
tzn_release_scripts
branch
from
a287f56
to
0b0c9f4
Compare
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index 1a49cfa..ca65095 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -11,5 +11,5 @@ a66ae0cd273779a749283ca4ceb24248b1720552f0cb0e52e472de692fd908e9 ./examples/bin
631bd7025cabd2fc74a0a266e889666df7fee6c928cb8fdd9abf338ed0d4425e ./examples/bin/proxy_attestation_example.wasm
a40f2de5ad1423cb2f5d06e3bd07532a1e882c8da97e18f792df81b242ab6115 ./examples/bin/translator.wasm
40a07fbbabbeef9ff2dbd3a29b5c256977d7fad8a50d765ff9cc023146d0b1c9 ./examples/bin/trusted_database.wasm
-a672301e33bbd9926a5ebdba95069c42ae579c2f37446f7ce1b2913c45b23da7 ./oak_loader/bin/oak_loader
+2b8aaea534b5a97369f43920f0cec1e3d5e562d0192413ae67063256400958a1 ./oak_loader/bin/oak_loader
cb255dbbea86b128379995ff7dc805fd026e2d21c997a8df688ba9e5cb98e1c1 ./oak_functions/loader/bin/oak_functions_loader
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that currently the hashes do not actually match those in the checked in index, but there seems to be some other non-determinism involved. Anyways, that should probably be sorted out separately in a future PR.