Selecting zcl properties and generate template files in a login page #630
Conversation
|
Please see the 4 issues mentioned in the image. Also rebase this branch to resolve the conflicts |
| } | ||
|
|
||
| /** | ||
| * Returns a promise that resolves into an array of objects containing 'sessionId', 'sessionKey' and 'creationTime' and assigned packages. |
There was a problem hiding this comment.
Function description should mention the dirty sessions and what that is for more clarity
src-electron/db/query-session.js
Outdated
| * @param {*} sessionId | ||
| * @param {*} userRef | ||
| * @param {*} sessionKey | ||
| * @returns A promise that resolves with the number of rows updated. |
There was a problem hiding this comment.
This does not seem right. Is more than one row actually updated or just one row?
src-electron/rest/initialize.js
Outdated
|
|
||
| module.exports.packagesAndSessions = (db) => { | ||
| return async (req, res) => { | ||
| const zclAttributes = await queryPackage.getPackagesByType( |
There was a problem hiding this comment.
zclAttributes can be confusing here. may be just go with zclProperties
| }) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Provide description for each of the additions here.
| @@ -55,7 +55,13 @@ function checksum(data) { | |||
| * @param {*} options: object containing 'zcl' and 'template' | |||
| * @returns Promise that resolves with the packages array. | |||
| */ | |||
| async function initializeSessionPackage(db, sessionId, options) { | |||
There was a problem hiding this comment.
Update function description
src-electron/util/util.js
Outdated
| db, | ||
| sessionId, | ||
| options, | ||
| selectedProperties = null, |
There was a problem hiding this comment.
is this selectedZclPropertyPackage?
src-electron/util/util.js
Outdated
| sessionId, | ||
| options, | ||
| selectedProperties = null, | ||
| selectedGen = null |
There was a problem hiding this comment.
is this selectedGenTemplatePackage?
|
|
||
| if (`debugNavBar` in query) { |
There was a problem hiding this comment.
Get rid of all the additional diff so that only the actual changes show up.
Amirreza-Ghasemkhani
force-pushed
the
tdj_555_7/7/2022
branch
from
5014300
to
8b768cf
Compare
Amirreza-Ghasemkhani
force-pushed
the
tdj_555_7/7/2022
branch
2 times, most recently
from
c22e723
to
e1af444
Compare
tecimovic
force-pushed
the
tdj_555_7/7/2022
branch
from
f4601f0
to
0aee6b8
Compare
…roject-chip#630) * Implement the initial selection of the valid sessions and property files. Co-authored-by: Timotej Ecimovic <[email protected]>
Resolved issues:
#555
#554
#351