Skip to content

Commit

Permalink
disable identify event for now
Browse files Browse the repository at this point in the history
  • Loading branch information
negrel committed Jul 18, 2024
1 parent 7450ca3 commit b9c727d
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 41 deletions.
35 changes: 19 additions & 16 deletions pkg/handlers/events_identify.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,26 @@ func ProvidePostEventsIdentify(
return fiber.NewError(fiber.StatusBadRequest, "content type is not application/json")
}

// Referrer of the POST request, that is the viewed page.
requestReferrer := peekReferrerHeader(c)
return nil

data := dataview.NewJsonData(bodyOrEmptyJsonObj(c))
return eventIdentifyHandler(
c.UserContext(),
logger,
eventStore,
saltManagerService,
sessionStorage,
requestReferrer,
c.Request().Header.UserAgent(),
utils.UnsafeBytes(c.IP()),
dataview.JsonKvView{Json: data},
dataview.JsonKvCollector{Json: data, Path: "set."},
dataview.JsonKvCollector{Json: data, Path: "setOnce."},
)
// TODO: fix identify event.
// Referrer of the POST request, that is the viewed page.
// requestReferrer := peekReferrerHeader(c)
//
// data := dataview.NewJsonData(bodyOrEmptyJsonObj(c))
// return eventIdentifyHandler(
// c.UserContext(),
// logger,
// eventStore,
// saltManagerService,
// sessionStorage,
// requestReferrer,
// c.Request().Header.UserAgent(),
// utils.UnsafeBytes(c.IP()),
// dataview.JsonKvView{Json: data},
// dataview.JsonKvCollector{Json: data, Path: "set."},
// dataview.JsonKvCollector{Json: data, Path: "setOnce."},
// )
}
}

Expand Down
51 changes: 26 additions & 25 deletions pkg/handlers/noscript_events_identify.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ package handlers

import (
"github.com/gofiber/fiber/v2"
"github.com/gofiber/fiber/v2/utils"
"github.com/prismelabs/analytics/pkg/dataview"
"github.com/prismelabs/analytics/pkg/embedded"
"github.com/prismelabs/analytics/pkg/services/eventstore"
"github.com/prismelabs/analytics/pkg/services/saltmanager"
Expand All @@ -27,29 +25,32 @@ func ProvideGetNoscriptEventsIdentify(
return err
}

// Referrer of the POST request, that is the viewed page.
requestReferrer := peekReferrerHeader(c)
return nil

return eventIdentifyHandler(
c.UserContext(),
logger,
eventStore,
saltManagerService,
sessionStorage,
requestReferrer,
c.Request().Header.UserAgent(),
utils.UnsafeBytes(c.IP()),
dataview.FasthttpArgsKvView{Args: c.Context().QueryArgs()},
dataview.FasthttpArgsKeysValuesCollector{
Args: c.Context().QueryArgs(),
Prefix: "set-",
ValueValidator: dataview.JsonValidator,
},
dataview.FasthttpArgsKeysValuesCollector{
Args: c.Context().QueryArgs(),
Prefix: "set-once-",
ValueValidator: dataview.JsonValidator,
},
)
// TODO: fix identify event.
// Referrer of the POST request, that is the viewed page.
// requestReferrer := peekReferrerHeader(c)
//
// return eventIdentifyHandler(
// c.UserContext(),
// logger,
// eventStore,
// saltManagerService,
// sessionStorage,
// requestReferrer,
// c.Request().Header.UserAgent(),
// utils.UnsafeBytes(c.IP()),
// dataview.FasthttpArgsKvView{Args: c.Context().QueryArgs()},
// dataview.FasthttpArgsKeysValuesCollector{
// Args: c.Context().QueryArgs(),
// Prefix: "set-",
// ValueValidator: dataview.JsonValidator,
// },
// dataview.FasthttpArgsKeysValuesCollector{
// Args: c.Context().QueryArgs(),
// Prefix: "set-once-",
// ValueValidator: dataview.JsonValidator,
// },
// )
}
}
File renamed without changes.

0 comments on commit b9c727d

Please sign in to comment.