Skip to content

Commit

Permalink
chore: Pin golang to 1.17 to avoid CVEs in docker image (argoproj#1920)
Browse files Browse the repository at this point in the history
Signed-off-by: Benoit Duverger <[email protected]>
  • Loading branch information
bduverger authored Apr 11, 2022
1 parent 589e896 commit 633892d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
- name: Setup Golang
uses: actions/setup-go@v2
with:
go-version: 1.17.6
go-version: 1.17

- name: Generate release artifacts
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Initial stage which pulls prepares build dependencies and CLI tooling we need for our final image
# Also used as the image in CI jobs so needs all dependencies
####################################################################################################
FROM --platform=$BUILDPLATFORM golang:1.17.6 as builder
FROM --platform=$BUILDPLATFORM golang:1.17 as builder

RUN apt-get update && apt-get install -y \
wget \
Expand Down Expand Up @@ -40,7 +40,7 @@ RUN NODE_ENV='production' yarn build
####################################################################################################
# Rollout Controller Build stage which performs the actual build of argo-rollouts binaries
####################################################################################################
FROM --platform=$BUILDPLATFORM golang:1.17.6 as argo-rollouts-build
FROM --platform=$BUILDPLATFORM golang:1.17 as argo-rollouts-build

WORKDIR /go/src/github.com/argoproj/argo-rollouts

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
####################################################################################################
# argo-rollouts-dev
####################################################################################################
FROM golang:1.17.6 as builder
FROM golang:1.17 as builder

RUN apt-get update && apt-get install -y \
ca-certificates && \
Expand Down

0 comments on commit 633892d

Please sign in to comment.