Replace deprecated lookupType and subDictPtr with get and findDict #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to have a look at the compiler output 😉 Very cool! |
|
I checked with the following versions:
Therefore, we should offer |
|
Ok, then the decision is up to you.If you still want to merge it we should document the compatibility somewhere. |
Good point, I updated the documentation page here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172.
This should work with all ESI versions since
v1806(update: since v1812). I want to check building this with that v1806 and maybe v1712 before merging.Now, building with v2012 gives no warnings! 🎉
@davidscn mainly FYI, you may want to have a look at the diff.