Update master #163
Merged
Update master #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case is currently ill-defined.
Also fix bugs (typos) in PressureGradient. The tutorial case is still ill-defined.
Still ill-defined. Cylindrical mesh from https://github.com/MakisH/openfoam_bubble_column/tree/master/short_bubbleFoam_da3_Ua02
Some parameters (especially in the thermodynamicProperties files) are completely abitrary, copied from the OpenFOAM 5 bundled tutorial for sonicLiquidFoam.
Updates for: - preCICE v2 - preciceDict replacing precice-adapter-config.yml - ability to act as a 2D solver - mesh connectivity and more. Some indentation issues came up during merging, most of the code should be consistent now.
Add a warning for faceNode case
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Add Assertion for xy-plane for 2D cases
Turn off debug messages by default
Remove tutorials
Move documentation to develop
* Remove double-quotes on command-line argument * Move wmake to a function Co-authored-by: Gerasimos Chourdakis <[email protected]>
The documentation and the tutorials were moved to the preCICE website: https://www.precice.org/
davidscn
approved these changes
Apr 15, 2021
|
Thank you! I will also add a CHANGELOG, actually, we have delayed this too long. |
|
I also removed the Travis badge from the README, as Travis is not in a valid state at the moment. I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a long time since we updated
master, but it is now the time to, together with the restructured tutorials.A lot has happened since the last update:
docs/folder here. These pages are now rendered in the new adapter documentation.faceCentersfor Displacement based reading #147Forceclass. See Refactor Force based data sets #148AllwmakeandAllcleanscripts, dropping support for preCICE 1.x. See More robust building scripts #157@davidscn have I forgotten anything else worth mentioning?