This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Give Subreddit Stats user the option to enter a subreddit name if he didn't include it in the arguments #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -450,7 +450,20 @@ def main(): | |||
|
|
|||
| options, args = parser.parse_args() | |||
| if len(args) != 1: | |||
| parser.error('Must provide subreddit') | |||
| print('Enter subreddit name:') | |||
| # Gets string that contains only alphanumeric characters (or "_") and | |||
There was a problem hiding this comment.
Please remove the subreddit validation as PRAW will raise an exception if the subreddit is not valid. Simpler is better. If you want to handle whatever exception is raised with an appropriate error message, that would be awesome.
|
Please address the inline comment. Otherwise I think this is an awesome addition. |
|
Made requested changes. |
bboe
added a commit
that referenced
this pull request
Feb 28, 2013
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Feel free to change whatever is necessary, and give feedback on the quality of this pull request.