Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added request id omit flag #303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added request id omit flag #303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d183672
added request id omit flag
marcosmol204 Aug 14, 2023
dcd1071
moved sinon import
marcosmol204 Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
moved sinon import
  • Loading branch information
@marcosmol204
marcosmol204 committed Aug 14, 2023
commit dcd10718e89b75ea583322ae55ccccc8834ef2f8
2 changes: 1 addition & 1 deletion src/code-templates/libraries/request-context/test/request-context.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import sinon from 'sinon';
import { context } from '../index';
import sinon from 'sinon';

Check failure on line 2 in src/code-templates/libraries/request-context/test/request-context.test.ts

View workflow job for this annotation

GitHub Actions / build (16.x, ubuntu-latest) 

`sinon` import should occur before import of `../index`

Check failure on line 2 in src/code-templates/libraries/request-context/test/request-context.test.ts

View workflow job for this annotation

GitHub Actions / build (18.x, ubuntu-latest) 

`sinon` import should occur before import of `../index`

describe('request-context', () => {
test('When instantiating a new context with initial values, then should get back the context', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/code-templates/libraries/request-context/test/request-id-express-middleware.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import express, { Express } from 'express';
import { Server } from 'http';
import { AddressInfo } from 'net';
import axios from 'axios';
import sinon from 'sinon';
import { addRequestIdExpressMiddleware, context } from '../index';
import { REQUEST_ID_HEADER } from '../src/request-id/constant';
import sinon from 'sinon';

let currentServer: Server;

Expand Down
Loading