Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent atom effect from overwriting state when batching set's #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent atom effect from overwriting state when batching set's #37

wants to merge 1 commit into from

Conversation

bartvanremortele
Copy link

Fixes #35

@polemius
Copy link
Owner

Thank you for PR. I have run test against this PR and these two are failing:

Storage: async
    ✕ should remove key from storage if reset (83 ms)
    ✕ should update storage if using atomFamily (16 ms)

Could you please check it?

@stefanoTron stefanoTron mentioned this pull request May 21, 2021
Open
@insaindesign
Copy link

It's a little ugly, but i had a go at fixing this for async storage: insaindesign@0811319.

Note it depends on the changes I had made in https://github.com/polemius/recoil-persist/pull/55/files (all storage to async).

@polemius polemius force-pushed the master branch 2 times, most recently from 050c87f to 2f70d34 Compare May 17, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async/await causes a race condition in React
3 participants
@bartvanremortele @polemius @insaindesign