Fix mismatched rdap keys

[pogzyb]

Fixes:

• Fix mismatched keys in rdap and whois methods #64

[codecov]

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (9dc7ad0) 88.62% compared to head (7b3260d) 85.84%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   88.62%   85.84%   -2.78%     
==========================================
  Files           8        8              
  Lines        2821     2960     +139     
==========================================
+ Hits         2500     2541      +41     
- Misses        321      419      +98     

Files	Coverage Δ
asyncwhois/parse_rir.py	31.73% <ø> (ø)
asyncwhois/query.py	78.43% <100.00%> (ø)
asyncwhois/parse.py	94.41% <92.85%> (-0.17%)	⬇️
asyncwhois/pywhois.py	44.66% <50.00%> (+1.93%)	⬆️
asyncwhois/parse_tld.py	76.58% <74.07%> (-13.12%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[y-polyakov-ddl]

This actually broke the functionality, advertised in the main README: both rdap methods now return None for bitcoin.org registrar.
Reason:

def convert_whodap_keys(parser_output: dict) -> dict:
    conversions = [  # snip
        (TLDBaseKeys.REGISTRAR, "registrar_name", False),  # 'registrar'
    ]
    for asyncwhois_key, whodap_key, keep in conversions:
        if keep:
            parser_output[asyncwhois_key] = parser_output.get(whodap_key)
        else:
            parser_output[asyncwhois_key] = parser_output.pop(whodap_key)

    # at this point, parser_output['registrar'] is the registrar name

    non_whodap_keys = [
       TLDBaseKeys.REGISTRAR,  # also 'registrar'
    ]
    for key in non_whodap_keys:
        parser_output[key] = None  # overwrites any value present in parser_output

   # at this point, parser_output['registrar'] is None

The easiest fix would probably be to remove this key, present in conversions, from non_whodap_keys.

[pogzyb]

This actually broke the functionality, advertised in the main README: both rdap methods now return None for bitcoin.org registrar. Reason:

def convert_whodap_keys(parser_output: dict) -> dict:
    conversions = [  # snip
        (TLDBaseKeys.REGISTRAR, "registrar_name", False),  # 'registrar'
    ]
    for asyncwhois_key, whodap_key, keep in conversions:
        if keep:
            parser_output[asyncwhois_key] = parser_output.get(whodap_key)
        else:
            parser_output[asyncwhois_key] = parser_output.pop(whodap_key)

    # at this point, parser_output['registrar'] is the registrar name

    non_whodap_keys = [
       TLDBaseKeys.REGISTRAR,  # also 'registrar'
    ]
    for key in non_whodap_keys:
        parser_output[key] = None  # overwrites any value present in parser_output

   # at this point, parser_output['registrar'] is None

The easiest fix would probably be to remove this key, present in conversions, from non_whodap_keys.

Thanks for pointing this out! I added your suggestion and rolled it into v1.1.4.