Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of package references #3

Merged
merged 1 commit into from
Jul 4, 2013
Merged

Conversation

bsl-zcs
Copy link

@bsl-zcs bsl-zcs commented Jul 4, 2013

It makes possible to use several additional language constructs (tuples, case classes, java static methods, fully qualified class names, etc.) in expectations, which previously refused to compile with a messages like “inferred type arguments [scala.type] do not conform to method recordValue's type parameter bounds [U]”.

(cherry picked from commit 6add585)
@buildhive
Copy link

Peter Niederwieser » expecty #21 SUCCESS
This pull request looks good
(what's this?)

pniederw added a commit that referenced this pull request Jul 4, 2013
Proper handling of package references
@pniederw pniederw merged commit b4fa063 into pniederw:master Jul 4, 2013
@ghost ghost assigned pniederw Jul 4, 2013
@pniederw
Copy link
Owner

pniederw commented Jul 4, 2013

Thanks a lot for the pull request! Are you aware of anything else that screams to be fixed before going 1.0?

@bsl-zcs
Copy link
Author

bsl-zcs commented Jul 5, 2013

Our shortlist of annoyances, which we accumulated in about a month of active use, is already addressed. Since then we haven’t use the library enough to gather a new one, so for now I’m not aware of any blocking issues with it.

som-snytt pushed a commit to som-snytt/expecty that referenced this pull request May 15, 2024
fix unmanagedSourceDirectories setting for Scala 2.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants