fix(ScreenSizer): use relative import #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The broken import causes a type error in the TS declaration files.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fcf6f28:
|
Methuselah96
added a commit
to Methuselah96/drei
that referenced
this pull request
Feb 3, 2024
This was preventing the type error that was fixed in pmndrs#1810 from being caught.
1 task
This was preventing the type error that was fixed in pmndrs#1810 from being caught.
CodyJasonBennett
changed the title
|
🎉 This PR is included in version 9.97.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The broken import causes a type error in the TS declaration files.
What
Fixed the import path and removed the
baseUrlsetting from the TSConfig to prevent it in the future.Checklist