Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes_jni linkopt select #517

Merged
merged 1 commit into from
Sep 26, 2024
Merged

hermes_jni linkopt select #517

merged 1 commit into from
Sep 26, 2024

Conversation

brocollie08
Copy link
Contributor

@brocollie08 brocollie08 commented Sep 26, 2024

Do not use android specific flags for hermes_jni host builds (testing purposes)

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@brocollie08 brocollie08 added the skip-release Preserve the current version when merged label Sep 26, 2024
@brocollie08 brocollie08 marked this pull request as ready for review September 26, 2024 18:34
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (f270369) to head (499d3ee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         341      341           
  Lines       27232    27232           
  Branches     1944     1944           
=======================================
  Hits        25026    25026           
  Misses       2192     2192           
  Partials       14       14           
Flag Coverage Δ
91.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brocollie08 brocollie08 merged commit 1a78aa4 into main Sep 26, 2024
11 checks passed
@brocollie08 brocollie08 deleted the fix-jvm-test-local branch September 26, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants