Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:no matching toolchains:ninja_toolchain #490

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Conversation

cehan-Chloe
Copy link
Collaborator

@cehan-Chloe cehan-Chloe commented Aug 16, 2024

fix for build error:

BUILD.bazel:35:6: While resolving toolchains for target @fbjni//:host: No matching toolchains found for types 
@rules_foreign_cc~0.10.1//toolchains:ninja_toolchain.
To debug, rerun with --toolchain_resolution_debug='@rules_foreign_cc~0.10.1//toolchains:ninja_toolchain'

solution:
upgrade rules_foreign_cc to the latest version
https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.11.1

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@cehan-Chloe cehan-Chloe marked this pull request as ready for review August 16, 2024 17:48
KetanReddy
KetanReddy previously approved these changes Aug 16, 2024
@sugarmanz sugarmanz added the skip-release Preserve the current version when merged label Aug 16, 2024
brocollie08
brocollie08 previously approved these changes Aug 16, 2024
sugarmanz
sugarmanz previously approved these changes Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (583b4c0) to head (2b55b22).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         340      340           
  Lines       26960    26960           
  Branches     1945     1945           
=======================================
  Hits        24796    24796           
  Misses       2150     2150           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy dismissed stale reviews from sugarmanz, brocollie08, and themself via 5a3529c August 19, 2024 18:24
@KetanReddy KetanReddy merged commit e8f3a23 into main Aug 20, 2024
11 checks passed
@KetanReddy KetanReddy deleted the fix-ninja-toolchain branch August 20, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants