-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build process update #160
Merged
Merged
Build process update #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
reviewed
Feb 9, 2022
willeastcott
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great step forward, @ellthompson! Awesome.
Co-authored-by: Will Eastcott <[email protected]>
ellthompson
commented
Feb 9, 2022
@@ -9,7 +9,7 @@ | |||
|
|||
> .pcui-numeric-input { | |||
flex: 1; | |||
margin: $element-margin $element-margin / 2; | |||
margin: $element-margin calc($element-margin / 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yay, you fixed those warnings in the build process. Nice job. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconfigured the PCUI build process to extend it's support of modules. The build step now generates module index files in the dist folder which export all of the individual components. It includes export statements like the ones below:
This means the full directory structure of the project is maintained in the dist folder (offering full ESM support in node and the browser) while still enabling the importing of individual components from the main module directory of the library.
The UMD version of PCUI is still available under
dist/index.js
. The react components are accessible from the moduledist/react/index.mjs
, while all es6 element classes and binding classes are also available under the moduledist/index.mjs
.The docs and readme have been updated to support this new build.
The package.json has been updated with main and module paths and a files list which defines what should be included in the npm bundle. I've removed the
npm run pcui:publish
script as we can now publish the library directly using thenpm publish
command.