We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The implementation of #9425 included migration code that extended the length of any identified locale columns. However, some of these columns (e.g. publication_galleys.locale) are nullable, and this code will either make them NOT NULL or, if there is null data present, fail with an error.
locale
NOT NULL
I would suggest altering the migration to make it preserve the NOT NULL status of the column when extending the length.
@jyhein and @ajnyga, just a heads-up -- @touhidurabir would like to fix it.
PRs pkp-lib --> #10305 ojs --> pkp/ojs#4398 [TEST ONLY]
The text was updated successfully, but these errors were encountered:
thanks, go ahead
Sorry, something went wrong.
pkp#10293 Null data preservation on locale related column update
4b88737
pkp/pkp-lib#10293 Submodule Update ##touhidurabir/i10293_main##
e445e44
@asmecher tests are passing , can you take a look at the PR at #10293 (comment)
@ajnyga, could you or @jyhein review this one? Thanks!
@ajnyga or @jyhein, this is breaking just about everything on upgraded installations; could you have a look at the PRs above?
touhidurabir
pkp-dev-infrastructure
No branches or pull requests
The implementation of #9425 included migration code that extended the length of any identified
locale
columns. However, some of these columns (e.g. publication_galleys.locale) are nullable, and this code will either make themNOT NULL
or, if there is null data present, fail with an error.I would suggest altering the migration to make it preserve the
NOT NULL
status of the column when extending the length.@jyhein and @ajnyga, just a heads-up -- @touhidurabir would like to fix it.
PRs
pkp-lib --> #10305
ojs --> pkp/ojs#4398 [TEST ONLY]
The text was updated successfully, but these errors were encountered: