Only validate public address when IP address is supplied on TCP/TLS #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also update the doc of Make sure to test that it works well. Also, I'm curious, how does Contact and Via rewrite work with FQDN published address? |
sauwming
approved these changes
Jun 27, 2023
nanangizz
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When public address is supplied when starting TCP/TLS transport(e.g:
pjsip_tcp_transport_start2()), the address will be validated.The validation is not applied to UDP transport.
If the address supplied is unresolvable FQDN address, the transport will fail to start.
This PR will only validate the publish address if it is an IP address.