Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use @napi-rs/nice to support Windows #655

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Sep 14, 2024

  • @napi-rs/nice is easier to install on CI
  • @napi-rs/nice supports Windows

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks great, thanks for the contribution.

CI seems broken tho

@Brooooooklyn
Copy link
Contributor Author

@metcoder95 thanks, fixed

@metcoder95
Copy link
Member

Now Windows does not seems to be happy

@metcoder95 metcoder95 added the backport v4 Backport work label related with v4.x label Sep 15, 2024
@Brooooooklyn
Copy link
Contributor Author

Tests now passed on my Windows and Linux computer 🥇

@metcoder95
Copy link
Member

metcoder95 commented Sep 17, 2024

Let's adjust the test to distinguish between linux and windows scenarios 👍

@Brooooooklyn Brooooooklyn force-pushed the use-napi-rs-nice branch 4 times, most recently from 66258cb to c1d07d7 Compare September 17, 2024 16:09
@metcoder95 metcoder95 changed the title chore: use @napi-rs/nice to support Windows feat: use @napi-rs/nice to support Windows Sep 17, 2024
@metcoder95 metcoder95 merged commit c567394 into piscinajs:current Sep 17, 2024
13 checks passed
Copy link

The backport to v4 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v4 v4
# Navigate to the new working tree
cd .worktrees/backport-v4
# Create a new branch
git switch --create backport-655-to-v4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c56739465000f455fcf7abc2f83501054cab22a4
# Push it to GitHub
git push --set-upstream origin backport-655-to-v4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v4

Then, create a pull request where the base branch is v4 and the compare/head branch is backport-655-to-v4.

metcoder95 pushed a commit that referenced this pull request Sep 18, 2024
metcoder95 added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v4 Backport work label related with v4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants