Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow named import usage #517

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

clydin
Copy link
Contributor

@clydin clydin commented Feb 20, 2024

The main exports of the package are now available both as named exports from the package as well as the previously available properties from the default export. This removes the requirement to use the esModuleInterop TypeScript option but retains backward compatiblity for existing usage.

@clydin clydin changed the title feat: allow named export usage feat: allow named import usage Feb 20, 2024
@clydin clydin marked this pull request as draft February 20, 2024 15:57
@clydin clydin force-pushed the esm-exports branch 2 times, most recently from c8f60a2 to 0f367d4 Compare February 20, 2024 19:14
@clydin clydin marked this pull request as ready for review February 20, 2024 20:58
metcoder95
metcoder95 previously approved these changes Feb 21, 2024
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, thanks for the contribution!

src/entry.ts Outdated Show resolved Hide resolved
The main exports of the package are now available both as named exports
from the package as well as the previously available properties from
the default export. This removes the requirement to use the `esModuleInterop`
TypeScript option but retains backward compatiblity for existing usage.
@metcoder95 metcoder95 merged commit 6a7c6e1 into piscinajs:current Feb 21, 2024
7 checks passed
@clydin clydin deleted the esm-exports branch February 21, 2024 21:15
metcoder95 added a commit that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants