fix: close pool with minThreads=0 (#584)

piscinajs · Jun 4, 2024 · 776bacb · 776bacb
1 parent 285aa82
commit 776bacb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -620,6 +620,12 @@ class ThreadPool {
 
     const onPoolFlushed = () => new Promise<void>((resolve) => {
       const numberOfWorkers = this.workers.size;
+
+      if (numberOfWorkers === 0) {
+        resolve();
+        return;
+      }
+
       let numberOfWorkersDone = 0;
 
       const checkIfWorkerIsDone = (workerInfo: WorkerInfo) => {

diff --git a/test/pool-close.ts b/test/pool-close.ts
@@ -10,6 +10,12 @@ test('close()', async (t) => {
     t.pass('pool closed successfully');
   });
 
+  t.test('no pending tasks (with minThreads=0)', async (t) => {
+    const pool = new Piscina({ filename: resolve(__dirname, 'fixtures/sleep.js'), minThreads: 0 });
+    await pool.close();
+    t.pass('pool closed successfully');
+  });
+
   t.test('queued tasks waits for all tasks to complete', async (t) => {
     const pool = new Piscina({ filename: resolve(__dirname, 'fixtures/sleep.js'), maxThreads: 1 });