Merge pull request #53 from emersion/lax-parse-ssl-tlv

Don't make SSL_CN mandatory
pires · Nov 9, 2020 · 9d53ed5 · 9d53ed5
2 parents 84376ea + cd4b0ca
commit 9d53ed5
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/tlvparse/ssl.go b/tlvparse/ssl.go
@@ -116,7 +116,6 @@ func SSL(t proxyproto.TLV) (PP2SSL, error) {
 		return PP2SSL{}, err
 	}
 	versionFound := !ssl.ClientSSL()
-	var cnFound bool
 	for _, tlv := range ssl.TLV {
 		switch tlv.Type {
 		case proxyproto.PP2_SUBTYPE_SSL_VERSION:
@@ -139,10 +138,9 @@ func SSL(t proxyproto.TLV) (PP2SSL, error) {
 			if len(tlv.Value) == 0 || !utf8.Valid(tlv.Value) {
 				return PP2SSL{}, proxyproto.ErrMalformedTLV
 			}
-			cnFound = true
 		}
 	}
-	if !(versionFound && cnFound) {
+	if !versionFound {
 		return PP2SSL{}, proxyproto.ErrMalformedTLV
 	}
 	return ssl, nil