Fixes SUPPRESS_ERROR_PAGE warning after webview_flutter_android upgrade #2182

Manuito83 · 2024-06-15T08:56:07Z

Connection with issue(s)

Resolve issue #2150

Testing and Review Notes

The SUPPRESS_ERROR_PAGE feature was discontinued according to this change in Webkit's WebViewFeature.java.

The recent upgrade of webkit to 1.10.0 in webview_flutter_android causes the webview to be null.

This suppresses references to SUPPRESS_ERROR_PAGE.

EArminjon · 2024-06-17T08:39:11Z

How override error pages if we no longer have disableDefaultErrorPage ?

Manuito83 · 2024-06-17T09:23:35Z

@EArminjon I can't say. This was a feature that was never launched in webkit:

Remove unlaunched suppressErrorPage API
Removing this abandoned API, which was never launched.

This is a change performed in WebViewFeature.java almost a year ago.

subzero911 · 2024-07-03T15:13:46Z

I need this fix ASAP, because I have this error.
A webview is just blank.

RaymondGsc · 2024-07-05T02:42:56Z

@pichillilorenzo I also need this fix, the webview just throw a SUPPRESS_ERROR_PAGE when opening.

Julied5 · 2024-07-11T12:40:05Z

your code does the trick but the webkit update gets me another error if i open a webview in a new flutter page and i pop it, the app just crashes :

E/AndroidRuntime( 4220): java.lang.IncompatibleClassChangeError: Found interface androidx.webkit.ScriptHandler, but class was expected (declaration of 'androidx.webkit.ScriptHandler' appears in /data/app/~~.......
E/AndroidRuntime( 4220): 	at com.pichillilorenzo.flutter_inappwebview_android.types.UserContentController.removeAllPluginScripts(UserContentController.java:310)

i guess it is because the webkit version in build.gradle is still in 1.8.0 (where the ScriptHandler is defined as an abstract class) and in the updated webkit (located in webview_flutter_android) the ScriptHandler is an interface, it creates a conflict between the two versions

if i replace with a newer webkit version (in android/build.gradle line 52) it fixes my bug :

dependencies {
    implementation 'androidx.webkit:webkit:1.11.0'
    implementation 'androidx.browser:browser:1.6.0'
    implementation 'androidx.appcompat:appcompat:1.6.1'
    implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
}

@Manuito83 can you tell me if you reproduce as well ?

Manuito83 · 2024-07-11T12:56:03Z

I was not getting this error with:

implementation 'androidx.webkit:webkit:1.10.0'

Julied5 · 2024-07-11T13:06:41Z

yes it also works with 1.10.0 but not with the actual one (1.8.0) defined in flutter_inappwebview_android/android/build.gradle

ndavis-rxss · 2024-07-17T19:25:36Z

LGTM

tkreuder · 2024-07-18T13:03:48Z

it worked for me and i bumped implementation 'androidx.webkit:webkit:1.11.0' in build.gradle:

pubspec.yaml

dependency_overrides:
  flutter_inappwebview_android:
    git:
      url: https://github.com/tkreuder/flutter_inappwebview.git
      ref: v6.0.0-fix-suppress-error-page
      path: flutter_inappwebview_android

EArminjon · 2024-07-19T09:01:29Z

Personally i make the fix different to still support disableDefaultErrorPage :

Old code

if (!WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) &&
      webView.customSettings.disableDefaultErrorPage) {}

New code (as feature no longer supported and so should match 'false')

if (webView.customSettings.disableDefaultErrorPage) {

I also updated webkit inside android/build.gradle

implementation 'androidx.webkit:webkit:1.11.0'

I can create a new PR for that.

EArminjon · 2024-07-19T09:07:12Z

.../pichillilorenzo/flutter_inappwebview_android/webview/in_app_webview/InAppWebViewClient.java

@@ -299,12 +299,6 @@ public void onReceivedError(WebView view, @NonNull WebResourceRequest request, @
  public void onReceivedError(WebView view, int errorCode, String description, String failingUrl) {
    final InAppWebView webView = (InAppWebView) view;

-    if (!WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) &&
-            webView.customSettings.disableDefaultErrorPage) {


You can just remove !WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) and keep the if

EArminjon · 2024-07-19T09:07:16Z

...llilorenzo/flutter_inappwebview_android/webview/in_app_webview/InAppWebViewClientCompat.java

@@ -309,12 +309,6 @@ public void onReceivedError(@NonNull WebView view,
  public void onReceivedError(WebView view, int errorCode, String description, String failingUrl) {
    final InAppWebView webView = (InAppWebView) view;

-    if (!WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) &&


You can just remove !WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) and keep the if

EArminjon · 2024-07-19T09:07:54Z

flutter_inappwebview_platform_interface/lib/src/platform_webview_feature.dart

Please keep old code format. That make review very hard, didn't see what you have changed.

RaymondGsc · 2024-07-22T03:46:09Z

Personally i make the fix different to still support disableDefaultErrorPage :

Old code
if (!WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) &&
      webView.customSettings.disableDefaultErrorPage) {}
New code (as feature no longer supported and so should match 'false')
if (webView.customSettings.disableDefaultErrorPage) {
I also updated webkit inside android/build.gradle
implementation 'androidx.webkit:webkit:1.11.0'
I can create a new PR for that.

Please fix it, I need this update ASAP, thx.

EArminjon · 2024-07-22T07:19:44Z

Personally i make the fix different to still support disableDefaultErrorPage :
Old code
if (!WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) &&
      webView.customSettings.disableDefaultErrorPage) {}
New code (as feature no longer supported and so should match 'false')
if (webView.customSettings.disableDefaultErrorPage) {
I also updated webkit inside android/build.gradle
implementation 'androidx.webkit:webkit:1.11.0'
I can create a new PR for that.
Please fix it, I need this update ASAP, thx.

Can you test #2231 ?

ndavis-rxss · 2024-07-22T12:50:55Z

@pichillilorenzo

RaymondGsc · 2024-07-31T07:25:03Z

Personally i make the fix different to still support disableDefaultErrorPage :
Old code
if (!WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) &&
      webView.customSettings.disableDefaultErrorPage) {}
New code (as feature no longer supported and so should match 'false')
if (webView.customSettings.disableDefaultErrorPage) {
I also updated webkit inside android/build.gradle
implementation 'androidx.webkit:webkit:1.11.0'
I can create a new PR for that.
Please fix it, I need this update ASAP, thx.
Can you test #2231 ?

Yes, I have test #2231 , and

Personally i make the fix different to still support disableDefaultErrorPage :
Old code
if (!WebViewFeature.isFeatureSupported(WebViewFeature.SUPPRESS_ERROR_PAGE) &&
      webView.customSettings.disableDefaultErrorPage) {}
New code (as feature no longer supported and so should match 'false')
if (webView.customSettings.disableDefaultErrorPage) {
I also updated webkit inside android/build.gradle
implementation 'androidx.webkit:webkit:1.11.0'
I can create a new PR for that.
Please fix it, I need this update ASAP, thx.
Can you test #2231 ?

I have all the code checked, but I wonder how can I test your code on my own device.

jwbrown · 2024-08-23T23:40:33Z

I implemented

dependencies {
    implementation 'androidx.webkit:webkit:1.11.0'
    implementation 'androidx.browser:browser:1.6.0'
    implementation 'androidx.appcompat:appcompat:1.6.1'
    implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
}

in my projects build.gradle but am still getting the java.lang.IncompatibleClassChangeError

[AndroidInAppWebViewWidget] (android) AndroidInAppWebViewWidget calling "dispose" using []
E/AndroidRuntime(10863): FATAL EXCEPTION: main
E/AndroidRuntime(10863): Process: com.example.letts_news, PID: 10863
E/AndroidRuntime(10863): java.lang.IncompatibleClassChangeError: Found interface androidx.webkit.ScriptHandler, but class was expected (declaration of 'androidx.webkit.ScriptHandler' appears in /data/app/~~qjcoDlweDOdhaTmOimMemg==/com.example.letts_news-ubVVtKNAKvjVDbcv-qI7KA==/base.apk)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.types.UserContentController.removeAllPluginScripts(UserContentController.java:309)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.types.UserContentController.dispose(UserContentController.java:470)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.webview.in_app_webview.InAppWebView.dispose(InAppWebView.java:2065)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.webview.in_app_webview.FlutterWebView.dispose(FlutterWebView.java:154)
E/AndroidRuntime(10863): 	at io.flutter.plugin.platform.PlatformViewsController$1.dispose(PlatformViewsController.java:254)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.systemchannels.PlatformViewsChannel$1.dispose(PlatformViewsChannel.java:150)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.systemchannels.PlatformViewsChannel$1.onMethodCall(PlatformViewsChannel.java:58)
E/AndroidRuntime(10863): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:267)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:292)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)
E/AndroidRuntime(10863): 	at android.os.Handler.handleCallback(Handler.java:942)
E/AndroidRuntime(10863): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(10863): 	at android.os.Looper.loopOnce(Looper.java:201)
E/AndroidRuntime(10863): 	at android.os.Looper.loop(Looper.java:288)
E/AndroidRuntime(10863): 	at android.app.ActivityThread.main(ActivityThread.java:7872)
E/AndroidRuntime(10863): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(10863): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
E/AndroidRuntime(10863): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

I've been stuck on this for most of the day so any direction would be appreciated

EArminjon · 2024-08-24T06:01:11Z

I implemented

dependencies {
    implementation 'androidx.webkit:webkit:1.11.0'
    implementation 'androidx.browser:browser:1.6.0'
    implementation 'androidx.appcompat:appcompat:1.6.1'
    implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
}

in my projects build.gradle but am still getting the java.lang.IncompatibleClassChangeError

[AndroidInAppWebViewWidget] (android) AndroidInAppWebViewWidget calling "dispose" using []
E/AndroidRuntime(10863): FATAL EXCEPTION: main
E/AndroidRuntime(10863): Process: com.example.letts_news, PID: 10863
E/AndroidRuntime(10863): java.lang.IncompatibleClassChangeError: Found interface androidx.webkit.ScriptHandler, but class was expected (declaration of 'androidx.webkit.ScriptHandler' appears in /data/app/~~qjcoDlweDOdhaTmOimMemg==/com.example.letts_news-ubVVtKNAKvjVDbcv-qI7KA==/base.apk)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.types.UserContentController.removeAllPluginScripts(UserContentController.java:309)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.types.UserContentController.dispose(UserContentController.java:470)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.webview.in_app_webview.InAppWebView.dispose(InAppWebView.java:2065)
E/AndroidRuntime(10863): 	at com.pichillilorenzo.flutter_inappwebview_android.webview.in_app_webview.FlutterWebView.dispose(FlutterWebView.java:154)
E/AndroidRuntime(10863): 	at io.flutter.plugin.platform.PlatformViewsController$1.dispose(PlatformViewsController.java:254)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.systemchannels.PlatformViewsChannel$1.dispose(PlatformViewsChannel.java:150)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.systemchannels.PlatformViewsChannel$1.onMethodCall(PlatformViewsChannel.java:58)
E/AndroidRuntime(10863): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:267)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:292)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)
E/AndroidRuntime(10863): 	at io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)
E/AndroidRuntime(10863): 	at android.os.Handler.handleCallback(Handler.java:942)
E/AndroidRuntime(10863): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(10863): 	at android.os.Looper.loopOnce(Looper.java:201)
E/AndroidRuntime(10863): 	at android.os.Looper.loop(Looper.java:288)
E/AndroidRuntime(10863): 	at android.app.ActivityThread.main(ActivityThread.java:7872)
E/AndroidRuntime(10863): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(10863): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
E/AndroidRuntime(10863): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

I've been stuck on this for most of the day so any direction would be appreciated

You can try #2231

I use it inside a big app in production, it works well.

jwbrown · 2024-08-24T11:27:47Z

@EArminjon

Cannot thank you enough, this worked for me.

Strangely i could not just clone and checkout the PR and build - have some weird problems in my flutter config still.... I was however able to patch .pub-cache with the changes and it fixes the problem perfectly.

Again thanks! I hope the change is merged into the package

Jim

kassandra-all-win-software · 2024-09-18T16:12:21Z

it worked for me and i bumped implementation 'androidx.webkit:webkit:1.11.0' in build.gradle:

pubspec.yaml
dependency_overrides:
  flutter_inappwebview_android:
    git:
      url: https://github.com/tkreuder/flutter_inappwebview.git
      ref: v6.0.0-fix-suppress-error-page
      path: flutter_inappwebview_android

It's Works for me

pichillilorenzo · 2024-09-23T13:07:53Z

Released new version 6.1.0 with the fix, thanks!

abdallah-odeh · 2024-09-24T06:08:19Z

@pichillilorenzo is this update requires to have SDK version 3.5.0 or it might be used on a lower bound? because it's kinda high & not everyone has updated to latest version

The current Dart SDK version is 3.4.3.

Because app_namespace depends on flutter_inappwebview >=6.1.0 which requires SDK version >=3.5.0 <4.0.0, version solving failed.


You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on flutter_inappwebview: flutter pub add flutter_inappwebview:^6.0.0

pichillilorenzo · 2024-09-24T07:31:13Z

@abdallah-odeh currently the InAppWebView widget for MacOS is only supported correctly starting from Flutter version ">=3.24.0" (which is based on Dart 3.5.0)

Removed invalid references

1f9ee98

probot-autolabeler bot added android flutter/dart labels Jun 15, 2024

Manuito83 mentioned this pull request Jun 15, 2024

Android issue: Unknown feature SUPPRESS_ERROR_PAGE, webview not displaying at all #2150

Open

2 tasks

EArminjon suggested changes Jul 19, 2024

View reviewed changes

EArminjon mentioned this pull request Jul 22, 2024

feature/flutter-3.22.X #2231

Closed

3 tasks

pichillilorenzo closed this Sep 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes SUPPRESS_ERROR_PAGE warning after webview_flutter_android upgrade #2182

Fixes SUPPRESS_ERROR_PAGE warning after webview_flutter_android upgrade #2182

Manuito83 commented Jun 15, 2024

EArminjon commented Jun 17, 2024

Manuito83 commented Jun 17, 2024 •

edited

Loading

subzero911 commented Jul 3, 2024

RaymondGsc commented Jul 5, 2024

Julied5 commented Jul 11, 2024

Manuito83 commented Jul 11, 2024

Julied5 commented Jul 11, 2024

ndavis-rxss commented Jul 17, 2024

tkreuder commented Jul 18, 2024 •

edited

Loading

EArminjon commented Jul 19, 2024 •

edited

Loading

EArminjon Jul 19, 2024

EArminjon Jul 19, 2024

EArminjon Jul 19, 2024

RaymondGsc commented Jul 22, 2024 •

edited

Loading

EArminjon commented Jul 22, 2024

ndavis-rxss commented Jul 22, 2024

RaymondGsc commented Jul 31, 2024

jwbrown commented Aug 23, 2024

EArminjon commented Aug 24, 2024 •

edited

Loading

jwbrown commented Aug 24, 2024 •

edited

Loading

kassandra-all-win-software commented Sep 18, 2024

pichillilorenzo commented Sep 23, 2024

abdallah-odeh commented Sep 24, 2024

pichillilorenzo commented Sep 24, 2024 •

edited

Loading

Fixes SUPPRESS_ERROR_PAGE warning after webview_flutter_android upgrade #2182

Fixes SUPPRESS_ERROR_PAGE warning after webview_flutter_android upgrade #2182

Conversation

Manuito83 commented Jun 15, 2024

Connection with issue(s)

Testing and Review Notes

EArminjon commented Jun 17, 2024

Manuito83 commented Jun 17, 2024 • edited Loading

subzero911 commented Jul 3, 2024

RaymondGsc commented Jul 5, 2024

Julied5 commented Jul 11, 2024

Manuito83 commented Jul 11, 2024

Julied5 commented Jul 11, 2024

ndavis-rxss commented Jul 17, 2024

tkreuder commented Jul 18, 2024 • edited Loading

EArminjon commented Jul 19, 2024 • edited Loading

EArminjon Jul 19, 2024

Choose a reason for hiding this comment

EArminjon Jul 19, 2024

Choose a reason for hiding this comment

EArminjon Jul 19, 2024

Choose a reason for hiding this comment

RaymondGsc commented Jul 22, 2024 • edited Loading

EArminjon commented Jul 22, 2024

ndavis-rxss commented Jul 22, 2024

RaymondGsc commented Jul 31, 2024

jwbrown commented Aug 23, 2024

EArminjon commented Aug 24, 2024 • edited Loading

jwbrown commented Aug 24, 2024 • edited Loading

kassandra-all-win-software commented Sep 18, 2024

pichillilorenzo commented Sep 23, 2024

abdallah-odeh commented Sep 24, 2024

pichillilorenzo commented Sep 24, 2024 • edited Loading

Manuito83 commented Jun 17, 2024 •

edited

Loading

tkreuder commented Jul 18, 2024 •

edited

Loading

EArminjon commented Jul 19, 2024 •

edited

Loading

RaymondGsc commented Jul 22, 2024 •

edited

Loading

EArminjon commented Aug 24, 2024 •

edited

Loading

jwbrown commented Aug 24, 2024 •

edited

Loading

pichillilorenzo commented Sep 24, 2024 •

edited

Loading