Merge pull request Netflix#2770 from castrapel/acme_domain_suffix

Move ACME host validation logic prior to R53 host modification
phuongnguyentqn · Apr 27, 2019 · cf56300 · cf56300
2 parents 056dfc3 + 2e3cd98
commit cf56300
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lemur/plugins/lemur_acme/plugin.py b/lemur/plugins/lemur_acme/plugin.py
@@ -77,8 +77,9 @@ def start_dns_challenge(self, acme_client, account_number, host, dns_provider, o
         change_ids = []
 
         host_to_validate = self.maybe_remove_wildcard(host)
-        host_to_validate = self.maybe_add_extension(host_to_validate, dns_provider_options)
         dns_challenges = self.find_dns_challenge(host_to_validate, order.authorizations)
+        host_to_validate = self.maybe_add_extension(host_to_validate, dns_provider_options)
+
         if not dns_challenges:
             sentry.captureException()
             metrics.send('start_dns_challenge_error_no_dns_challenges', 'counter', 1)