Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect enum duplicated values #2371

Merged
merged 12 commits into from
May 23, 2023
Merged

Detect enum duplicated values #2371

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
892a7f9
Detect enum duplicated values
kubk May 4, 2023
5104fd6
Infer ->scalarType
kubk May 4, 2023
72a471e
Make test pass for PHP 8.0 too
kubk May 4, 2023
a0c4c3a
Additional enum rules
kubk May 4, 2023
1669aba
naming
kubk May 4, 2023
853df3c
rename identifier
kubk May 4, 2023
c2555dd
Fix CS
kubk May 4, 2023
1cfc7ac
Respect early return rule
kubk May 6, 2023
f9d0560
Fix for old PHP
kubk May 6, 2023
7edd4dd
Cosmetics
ondrejmirtes May 9, 2023
a27b32e
handle empty expr
kubk May 13, 2023
8dcd207
Fix bug that wasn't covered by tests
kubk May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename identifier
  • Loading branch information
@kubk @ondrejmirtes
kubk authored and ondrejmirtes committed May 9, 2023
commit 853df3cb5dd6bb5e47fe9152bebaf808921b3f45
2 changes: 1 addition & 1 deletion src/Rules/Classes/EnumSanityRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public function processNode(Node $node, Scope $scope): array
$caseName,
$stmt->expr->value,
))
->identifier('enum.caseTypeMismatch')
->identifier('enum.nonBackedEnumHasValue')
->line($stmt->getLine())
->nonIgnorable()
->build();
Expand Down