Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip cache_static_manifest config option with --no-assets flag #4902

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: skip cache_static_manifest config option with --no-assets flag #4902

merged 1 commit into from
Aug 10, 2022

Conversation

maximemenager
Copy link
Contributor

@maximemenager maximemenager commented Jul 28, 2022 •
edited
Loading

This PR skips the cache_static_manifest option which was added to the config/prod.exs even if the --no-assets flag was given during mix phx.new

Fixes #4893

@maximemenager maximemenager mentioned this pull request Jul 28, 2022
Closed
@chrismccord chrismccord merged commit 72d5366 into phoenixframework:master Aug 10, 2022
@chrismccord
Copy link
Member

❤️❤️❤️🐥🔥

@maximemenager maximemenager deleted the fix-cache-static-manifest-no-asset branch August 10, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:cache_static_manifest configuration is added in prod.exs with --no-assets phx.new option
2 participants
@maximemenager @chrismccord