Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKLOG-27676] Added config builder for credentials #72

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

bmorrise
Copy link

No description provided.

@wingman-pentaho
Copy link
Collaborator

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl '.' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl '.' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  src/main/java/org/pentaho/s3common/S3CommonFileSystem.java
  src/main/java/org/pentaho/s3common/S3CommonFileSystemConfigBuilder.java

Unit Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes: -1.4% (click to expand)
org.pentaho.s3common.S3CommonFileSystem
  • Complexity Change: -11.4% 🔻
  • Instruction Change: -5.7% 🔻
  • Line Change: -9.2% 🔻
🆕 org.pentaho.s3common.S3CommonFileSystemConfigBuilder
  • Complexity Coverage: 62.5%
  • Instruction Coverage: 58.1%
  • Line Coverage: 53.8%
  • Method Coverage: 62.5%

@bmorrise
Copy link
Author

@ddiroma

@ddiroma ddiroma merged commit 5681b5d into pentaho:master Jun 28, 2019
NJtwentyone pushed a commit to NJtwentyone/pentaho-s3-vfs that referenced this pull request Mar 20, 2020
[BACKLOG-27676] Added config builder for credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants